Skip to content

fix(b-carousel): fix glitching when switching slides fast (closes #5810) #5845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2020
Merged

fix(b-carousel): fix glitching when switching slides fast (closes #5810) #5845

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76500af
fix glitchingg
Hiws Oct 1, 2020
ca0561a
Update carousel.js
jacobmllr95 Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/components/carousel/carousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
getActiveElement,
reflow,
removeClass,
requestAF,
selectAll,
setAttr
} from '../../utils/dom'
Expand Down Expand Up @@ -269,7 +270,10 @@ export const BCarousel = /*#__PURE__*/ Vue.extend({
// Don't change slide while transitioning, wait until transition is done
if (this.isSliding) {
// Schedule slide after sliding complete
this.$once('sliding-end', () => this.setSlide(slide, direction))
this.$once('sliding-end', () => {
// Wrap in `requestAF()` to allow the slide to properly finish to avoid glitching
requestAF(() => this.setSlide(slide, direction))
})
return
}
this.direction = direction
Expand Down