-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(docs): improve Bootstrap/BootstrapVue style import guide in "Getting started" docs #6222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The original version was a little confusing because it was repetitive and missed the opportunity to make clear at the outset that there are potentially 3 SCSS files and they must be imported in order.
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/5dnaqe080 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9c2a971:
|
Codecov Report
@@ Coverage Diff @@
## dev #6222 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 299 299
Lines 10035 10035
Branches 2513 2513
=========================================
Hits 10035 10035
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Sorry! Thank you for updating. I have further clarified. Hopefully it is OK now?
@darrelfrancis I made some final adjustments. Are you fine with that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thank you!
The original version was a little confusing because it was repetitive and missed the opportunity to make clear at the outset that there are potentially 3 SCSS files and they must be imported in order.
Describe the PR
Simplify the documentation making clear the importance of the order, and exactly how to import
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).