Skip to content

fix(b-img-lazy): prefer computed props over user supplied ones #6302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2021
Merged

fix(b-img-lazy): prefer computed props over user supplied ones #6302

merged 2 commits into from
Jan 8, 2021

Conversation

kagawagao
Copy link
Contributor

@kagawagao kagawagao commented Jan 8, 2021 •
edited by jacobmllr95
Loading

Describe the PR

This PR makes sure that <b-img-lazy> prefers it's own computed props over the user supplied ones.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc.). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@kagawagao
fix(b-img-lazy): fix blank-src not work error
23899fc 
use BImgLazy computed value props overwrite default BImg props
@vercel
Copy link

vercel bot commented Jan 8, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/gisbxv37k
✅ Preview: https://bootstrap-vue-git-fork-kagawagao-dev.bootstrap-vue.now.sh

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 8, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5f37c1c:

Sandbox Source
BootstrapVue Starter Project Configuration
BootstrapVue Nuxt.js Starter Project Configuration

@codecov
Copy link

codecov bot commented Jan 8, 2021 •
edited
Loading

Codecov Report

Merging #6302 (23899fc) into dev (f4f597b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev     #6302   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          299       299           
  Lines        10105     10105           
  Branches      2512      2512           
=========================================
  Hits         10105     10105
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/image/img-lazy.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555f5e2...5f37c1c. Read the comment docs.

@jacobmllr95 jacobmllr95 self-requested a review January 8, 2021 14:15
@jacobmllr95 jacobmllr95 added PR: Patch Requires patch version bump Type: Fix labels Jan 8, 2021
@jacobmllr95 jacobmllr95 changed the title fix(b-img-lazy): fix blank-src not work error fix(b-img-lazy): prefer computed props over user supplied ones Jan 8, 2021
@jacobmllr95 jacobmllr95 merged commit a6ace2f into bootstrap-vue:dev Jan 8, 2021
@jacobmllr95
Copy link
Member

Thanks @kagawagao!

@kagawagao
Copy link
Contributor Author

@jackmu95 when will this patch be released?

@jacobmllr95 jacobmllr95 mentioned this pull request Jan 22, 2021
Closed
@Hiws Hiws mentioned this pull request Feb 24, 2021
Closed
@henriquebonfim henriquebonfim mentioned this pull request Aug 20, 2024
Open
This was referenced Sep 14, 2024
Open
Open
Open
@ashu1409 ashu1409 mentioned this pull request Sep 18, 2024
Open
@takawiramundure takawiramundure mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobmllr95 jacobmllr95 jacobmllr95 approved these changes

Assignees
No one assigned
Labels
PR: Patch Requires patch version bump Type: Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kagawagao @jacobmllr95