-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore(docs): use specific bootstrap and vue versions for cdn links #6623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): use specific bootstrap and vue versions for cdn links #6623
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/765z4jWmzPStRVnWUoh4sb1DP5YS |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3f6f840:
|
Codecov Report
@@ Coverage Diff @@
## dev #6623 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 305 305
Lines 10452 10452
Branches 2550 2550
=========================================
Hits 10452 10452
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution. |
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Describe the PR
Since Bootstrap 5 was released recently, the CDN links used in the examples around the docs will now fetch Bootstrap 5, instead of Bootstrap 4 as before. This means if people copy the examples, they wont work as expected.
Because of that this PR adds versions to the CDN links to ensure they will work as intended when people copy them directly.
I'm not super happy about the implementation in
main-docs.js
, to allow for importing the Bootstrap and Vue version. As it seems a bit hacky. However I couldn't find an alternative. So suggestions regarding that is welcome.PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: