Skip to content

chore(docs): use specific bootstrap and vue versions for cdn links #6623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 27, 2022

Conversation

Hiws
Copy link
Member

@Hiws Hiws commented May 18, 2021

Describe the PR

Since Bootstrap 5 was released recently, the CDN links used in the examples around the docs will now fetch Bootstrap 5, instead of Bootstrap 4 as before. This means if people copy the examples, they wont work as expected.

Because of that this PR adds versions to the CDN links to ensure they will work as intended when people copy them directly.

I'm not super happy about the implementation in main-docs.js, to allow for importing the Bootstrap and Vue version. As it seems a bit hacky. However I couldn't find an alternative. So suggestions regarding that is welcome.

PR checklist

What kind of change does this PR introduce? (check at least one)

  • Bugfix (fixes a boo-boo in the code) - fix(...), requires a patch version update
  • Feature (adds a new feature to BootstrapVue) - feat(...), requires a minor version update
  • Enhancement (augments an existing feature) - feat(...), requires a minor version update
  • ARIA accessibility (fixes or improves ARIA accessibility) - fix(...), requires a patch or minor version update
  • Documentation update (improves documentation or typo fixes) - chore(docs), requires a patch version update
  • Other (please describe)

Does this PR introduce a breaking change? (check one)

  • No
  • Yes (please describe since breaking changes require a minor version update)

The PR fulfills these requirements:

  • It's submitted to the dev branch, not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (i.e. [...] (fixes #xxx[,#xxx]), where "xxx" is the issue number)
  • It should address only one issue or feature. If adding multiple features or fixing a bug and adding a new feature, break them into separate PRs if at all possible.
  • The title should follow the Conventional Commits naming convention (i.e. fix(alert): not alerting during SSR render, docs(badge): update pill examples, chore(docs): fix typo in README, etc.). This is very important, as the CHANGELOG is generated from these messages, and determines the next version type (patch or minor).

If new features/enhancement/fixes are added or changed:

  • Includes documentation updates
  • Includes component package.json meta section updates (prop, slot and event changes/updates)
  • Includes any needed TypeScript declaration file updates
  • New/updated tests are included and passing (required for new features and enhancements)
  • Existing test suites are passing
  • CodeCov for patch has met target (all changes/updates have been tested)
  • The changes have not impacted the functionality of other components or directives
  • ARIA Accessibility has been taken into consideration (Does it affect screen reader users or keyboard only users? Clickable items should be in the tab index, etc.)

If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@Hiws Hiws requested a review from jacobmllr95 May 18, 2021 09:52
@vercel
Copy link

vercel bot commented May 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/765z4jWmzPStRVnWUoh4sb1DP5YS
✅ Preview: https://bootstrap-vue-git-fork-hiws-specify-specific-cdn-versio-d58e1a.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 18, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3f6f840:

Sandbox Source
BootstrapVue Starter Project Configuration
BootstrapVue Nuxt.js Starter Project Configuration

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #6623 (3f6f840) into dev (85a9e65) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev     #6623   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          305       305           
  Lines        10452     10452           
  Branches      2550      2550           
=========================================
  Hits         10452     10452           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@stale
Copy link

stale bot commented Mar 30, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution.

@stale stale bot added the Status: Stale label Mar 30, 2022
@stale
Copy link

stale bot commented Apr 16, 2022

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

@stale stale bot closed this Apr 16, 2022
@VividLemon VividLemon reopened this Dec 27, 2022
@vercel
Copy link

vercel bot commented Dec 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bootstrap-vue ✅ Ready (Inspect) Visit Preview Dec 27, 2022 at 3:43PM (UTC)

@stale stale bot removed the Status: Stale label Dec 27, 2022
@VividLemon VividLemon merged commit c597779 into bootstrap-vue:dev Dec 27, 2022
@Hiws Hiws deleted the specify-specific-cdn-versions branch December 28, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing custom-select style if latest bootstrap is used
2 participants