-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(docs) b-modal - move section on events emitted into own section #6946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The documentation on events emitted by the v-b-modal was buried at the end of "Toggle Modal Closing" -> "Prevent Closing" - this is not an appropriate place and made it very hard to find. This PR creates a top-level section "Events".
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bootstrap-vue/bootstrap-vue/DRPKmAqmCUG6JpZ562vWLd1HYeCE |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit efa18df:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## dev #6946 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 305 305
Lines 10452 10452
Branches 2550 2550
=========================================
Hits 10452 10452
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Describe the PR
The documentation on events emitted by the v-b-modal was buried at the end of "Toggle Modal Closing" -> "Prevent Closing" - this is not an appropriate place and made it very hard to find.
This PR creates a top-level section "Events".
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)
, requires a patch version updatefeat(...)
, requires a minor version updatefeat(...)
, requires a minor version updatefix(...)
, requires a patch or minor version updatechore(docs)
, requires a patch version updateDoes this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
dev
branch, not themaster
branch[...] (fixes #xxx[,#xxx])
, where "xxx" is the issue number)fix(alert): not alerting during SSR render
,docs(badge): update pill examples
,chore(docs): fix typo in README
, etc.). This is very important, as theCHANGELOG
is generated from these messages, and determines the next version type (patch or minor).If new features/enhancement/fixes are added or changed:
If adding a new feature, or changing the functionality of an existing feature, the PR's
description above includes: