fix(carousel): Handle changes in slide content #809
Conversation
Add `observedom` mixin to detect changes in slide content
|
I have temporarily removed carousel from docs sidebar. Do you think we are stable enough now to bring it back? |
|
Now includes fixes for slightly messed up transitions (blank space between sliding slides is now gone) Allows user to programmatically pause and restart the carousel by setting |
|
I think this version fixes many issues (although not positive if it has added any new "bugs") |
|
Also added updated docs/example for carousel |
| @@ -139,27 +140,35 @@ | |||
| }, | |||
| value: { | |||
| type: Number, | |||
| defrault: 0 | |||
There was a problem hiding this comment.
This was the main culprit of carousel not showing initially, as value defaulted to null/undefined if a v-model wasn't bound.
Codecov Report
@@ Coverage Diff @@
## dev #809 +/- ##
========================================
+ Coverage 39.61% 40% +0.39%
========================================
Files 68 68
Lines 2209 2217 +8
Branches 632 633 +1
========================================
+ Hits 875 887 +12
+ Misses 1172 1171 -1
+ Partials 162 159 -3
Continue to review full report at Codecov.
|
|
This should now be ready for testing before merge. |
|
Incorporated changes by @pi0 in the v4-beta branch |
Add
observedommixin to handle updates to slide content (and delayed rendering ofcarousel-slide)No guarantee that carousel is bug-free