fix(pagination): Change classes from .hidden-* to .d-* #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 tasks
|
Well this is inconvenient. Refactoring responsive breakpoint classes is not a favorite of mine... I suppose it saves on BS4's gratuitous lib size though. |
|
Yeah. Not sure of any other components that were using the The removal of these classes now mean you have to add at least two classes to your elements (one for hiding, and one for displaying), but it is more flexible |
|
It's a big deal for my production app. I'll be doing some find & replace by hand work when I upgrade... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V4.beta has removed the
.hidden-*classes, so we must use the.d-*classes for hiding on XS screens.For pagination and pagination-nav we replaced
.hidden-sx-downwith.d-none+.d-sm-flex