Skip to content

Conversation

tmorehouse
Copy link
Member

@tmorehouse tmorehouse commented Aug 14, 2017

Similar to native .row class, but created a row using .form-row class which has tighter margins.

Created as a functional component, and allows for a custom tag (defaults to div)

Includes tests

@tmorehouse tmorehouse added this to the v1.0.0 milestone Aug 14, 2017
@codecov-io
Copy link

Codecov Report

Merging #844 into 1.x will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             1.x     #844      +/-   ##
=========================================
+ Coverage   39.8%   39.85%   +0.05%     
=========================================
  Files         75       76       +1     
  Lines       2339     2341       +2     
  Branches     663      663              
=========================================
+ Hits         931      933       +2     
  Misses      1245     1245              
  Partials     163      163
Impacted Files Coverage Δ
lib/components/form-row.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 467ec27...a624d86. Read the comment docs.

@tmorehouse tmorehouse requested a review from pi0 August 14, 2017 21:04
@tmorehouse tmorehouse merged commit 1e0f313 into 1.x Aug 14, 2017
@tmorehouse tmorehouse deleted the tmorehouse-form-row branch August 14, 2017 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants