fix(BNavbar): changed autoClose to noAutoClose and fix the documention mistake about it. #2799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n mistake about it.
|
|
WalkthroughThe changes replace the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant BNavbar
participant BDropdownItem
participant BLink
participant Collapse
User->>BDropdownItem: Click dropdown item
BDropdownItem->>BNavbar: Check navbarData.noAutoClose
alt noAutoClose is not true
BDropdownItem->>Collapse: collapseData.hide()
end
User->>BLink: Click link
BLink->>BNavbar: Check navbarData.noAutoClose
alt noAutoClose is not true
BLink->>Collapse: collapseData.hide()
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (6)
🧰 Additional context used🧠 Learnings (13)📚 Learning: in bootstrap-vue-next, `popoverorchestratorparam` includes an `id` field of type `controllerkey` thr...Applied to files:
📚 Learning: in the `useblinktagresolver` function in `packages/bootstrap-vue-next/src/composables/useblinkhelper...Applied to files:
📚 Learning: the generic type parameter for table items should use the singular form `item` rather than the plura...Applied to files:
📚 Learning: in bootstrap-vue-next, the `usescrollspy` hook returns an object with a `current` property which is ...Applied to files:
📚 Learning: in btabs component (packages/bootstrap-vue-next/src/components/btabs/btabs.vue), the activeindex syn...Applied to files:
📚 Learning: in btabs component (packages/bootstrap-vue-next/src/components/btabs/btabs.vue), the activeindex and...Applied to files:
📚 Learning: the `` component in the bootstrap-vue-next documentation automatically renders t...Applied to files:
📚 Learning: in btabs component (packages/bootstrap-vue-next/src/components/btabs/btabs.vue), the complex initial...Applied to files:
📚 Learning: in global scss files for bootstrap-vue-next, `:deep()` combinator should not be used as it only work...Applied to files:
📚 Learning: btooltip is a very thin wrapper around bpopover in bootstrap-vue-next. there is no separate `usetool...Applied to files:
📚 Learning: in migration guides, links to the old/previous version's documentation (like bootstrap-vue.org) are ...Applied to files:
📚 Learning: in vue 3.3+, `toref(() => props.strategy)` creates a reactive readonly ref. this getter-based syntax...Applied to files:
📚 Learning: in vue 3.3 and later, `toref(() => props.strategy)` creates a reactive readonly ref. the getter-base...Applied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (8)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
6 tasks
commit: |
dwgray
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
A clear and concise description of what the pull request does.
Small replication
A small replication or video walkthrough can help demonstrate the changes made. This is optional, but can help observe the intended changes. A mentioned issue that contains a replication also works.
PR checklist
What kind of change does this PR introduce? (check at least one)
fix(...)feat(...)fix(...)docs(...)The PR fulfills these requirements:
CHANGELOGis generated from these messages, and determines the next version type. Pull requests that do not follow conventional commits or do not have an override will be deniedSummary by CodeRabbit
New Features
Refactor