Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Aug 19, 2025

  • Create comprehensive useScrollspy documentation page with examples and configuration options
  • Add useScrollspy entry to composables table of contents
  • Refactor examples into separate demo files following component documentation patterns
  • Convert fragment files to proper Vue files with TypeScript support
  • Add useScrollspy to TableOfContentsNav.vue for proper navigation
  • Update all demo files to use modern useTemplateRef() syntax
  • Add types documentation to types.md file
  • Fix TypeScript errors: resolve ref value access in UseScrollspyManual.vue and remove unused current variable in UseScrollspyBasic.vue
  • Fix PropertyKey TypeScript error by filtering list to exclude items with null ids
  • Add explicit PropertyKey type casting to resolve TypeScript compilation error

The useScrollspy composable documentation is now complete with working interactive examples, proper TypeScript support, and follows the established documentation patterns in the repository.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link
Contributor Author

Copilot AI commented Aug 19, 2025

@VividLemon 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Co-authored-by: VividLemon <31498096+VividLemon@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] useScrollspy documentation Add comprehensive useScrollspy documentation Aug 19, 2025
@Copilot Copilot AI requested a review from VividLemon August 19, 2025 23:45
Copilot finished work on behalf of VividLemon August 19, 2025 23:45
@VividLemon
Copy link
Member

@copilot A new copilot instruction file has been added

Co-authored-by: VividLemon <31498096+VividLemon@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Aug 19, 2025

@copilot A new copilot instruction file has been added

Thanks for letting me know! I've also cleaned up the PR by removing accidentally committed build artifacts and updated the .gitignore to prevent similar issues in the future (7fa3fd8).

Copilot finished work on behalf of VividLemon August 20, 2025 00:00
Copy link

coderabbitai bot commented Aug 26, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@VividLemon
Copy link
Member

@dwgray Can you review this please?

@VividLemon VividLemon marked this pull request as ready for review August 26, 2025 15:18
Copy link

pkg-pr-new bot commented Aug 26, 2025

bsvn-vite-ts

npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next@2812
npm i https://pkg.pr.new/bootstrap-vue-next/bootstrap-vue-next/@bootstrap-vue-next/nuxt@2812

commit: 372d922

@dwgray
Copy link
Member

dwgray commented Aug 26, 2025

@copilot please refactor the examples into their own files by creating a demo directory at the root of the .composables directory and placing them there. You can use components/nav.md as an example of how these demo files are referenced.

Moved all inline examples from useScrollspy.md into separate demo files following the established pattern used in components documentation:

- Created demo directory in composables
- Split examples into UseScrollspyBasic.vue, UseScrollspyManual.vue, and UseScrollspyCustomQuery.vue
- Updated markdown to reference demo files using <<< DEMO syntax
- Removed inline script setup and dependencies

Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Aug 26, 2025

@copilot please refactor the examples into their own files by creating a demo directory at the root of the .composables directory and placing them there. You can use components/nav.md as an example of...

Done! I've refactored all the examples into separate demo files following the pattern used in components documentation.

Created:

  • demo/UseScrollspyBasic.vue - Basic scroll tracking example
  • demo/UseScrollspyManual.vue - Manual mode example
  • demo/UseScrollspyCustomQuery.vue - Custom content query example

The markdown file now uses the <<< DEMO ./demo/FileName.vue#template{vue-html} syntax to reference these files. This follows the same pattern as components/nav.md and makes the documentation more maintainable.

Commit: f0c6bd5

Copilot finished work on behalf of dwgray August 26, 2025 19:00
@Copilot Copilot AI requested a review from dwgray August 26, 2025 19:00
Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
@Copilot Copilot AI requested a review from dwgray August 26, 2025 19:20
Copilot finished work on behalf of dwgray August 26, 2025 19:20
…e files, add types

Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
@Copilot Copilot AI requested a review from dwgray August 26, 2025 21:35
Copilot finished work on behalf of dwgray August 26, 2025 21:35
Copy link
Member

@dwgray dwgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot useBreadcrumb is not showing up in the table of contenst, it must be added to the composablesList in TableOfContentsNav.vue

Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Aug 26, 2025

@copilot useBreadcrumb is not showing up in the table of contenst, it must be added to the composablesList in TableOfContentsNav.vue

Added useScrollspy to the composablesList in TableOfContentsNav.vue. The composable will now appear in the table of contents. (fba1fba)

@Copilot Copilot AI requested a review from dwgray August 26, 2025 22:21
Copilot finished work on behalf of dwgray August 26, 2025 22:21
@VividLemon
Copy link
Member

@dwgray If there's nothing else, feel free to merge

@dwgray
Copy link
Member

dwgray commented Aug 28, 2025

@copilot please correct the two issues that I pointed out in my most recent review

Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Aug 28, 2025

@copilot please correct the two issues that I pointed out in my most recent review

Both TypeScript issues have been resolved:

  1. Fixed ref value access in UseScrollspyManual.vue
  2. Removed unused current variable in UseScrollspyBasic.vue
    (4c44beb)

@Copilot Copilot AI requested a review from dwgray August 28, 2025 20:02
Copilot finished work on behalf of dwgray August 28, 2025 20:02
Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
Copilot finished work on behalf of dwgray August 28, 2025 21:38
Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
Copilot finished work on behalf of dwgray August 28, 2025 21:52
Copy link
Member

@dwgray dwgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dwgray
Copy link
Member

dwgray commented Aug 28, 2025

@VividLemon I had to have copilot make additional changes (it wasn't building at the time you reviewed) - and since I collaborated with copilot on them, it counts as a self-review...

@VividLemon VividLemon merged commit 2538e00 into main Sep 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants