-
-
Notifications
You must be signed in to change notification settings - Fork 164
Add comprehensive useScrollspy documentation #2812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@VividLemon 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
|
Co-authored-by: VividLemon <31498096+VividLemon@users.noreply.github.com>
@copilot A new copilot instruction file has been added |
Co-authored-by: VividLemon <31498096+VividLemon@users.noreply.github.com>
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
@dwgray Can you review this please? |
commit: |
@copilot please refactor the examples into their own files by creating a demo directory at the root of the .composables directory and placing them there. You can use components/nav.md as an example of how these demo files are referenced. |
Moved all inline examples from useScrollspy.md into separate demo files following the established pattern used in components documentation: - Created demo directory in composables - Split examples into UseScrollspyBasic.vue, UseScrollspyManual.vue, and UseScrollspyCustomQuery.vue - Updated markdown to reference demo files using <<< DEMO syntax - Removed inline script setup and dependencies Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
Done! I've refactored all the examples into separate demo files following the pattern used in components documentation. Created:
The markdown file now uses the Commit: f0c6bd5 |
Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
apps/docs/src/docs/composables/demo/UseScrollspyCleanup.fragment
Outdated
Show resolved
Hide resolved
apps/docs/src/docs/composables/demo/UseScrollspyCustomRoot.fragment
Outdated
Show resolved
Hide resolved
apps/docs/src/docs/composables/demo/UseScrollspyDynamicContent.fragment
Outdated
Show resolved
Hide resolved
…e files, add types Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot useBreadcrumb is not showing up in the table of contenst, it must be added to the composablesList in TableOfContentsNav.vue
apps/docs/src/docs/composables/demo/UseScrollspyDynamicContent.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
@dwgray If there's nothing else, feel free to merge |
@copilot please correct the two issues that I pointed out in my most recent review |
Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
Co-authored-by: dwgray <5083020+dwgray@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@VividLemon I had to have copilot make additional changes (it wasn't building at the time you reviewed) - and since I collaborated with copilot on them, it counts as a self-review... |
The useScrollspy composable documentation is now complete with working interactive examples, proper TypeScript support, and follows the established documentation patterns in the repository.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.