Add headerAttrs prop to BOffcanvas and BModal components #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Co-authored-by: VividLemon <31498096+VividLemon@users.noreply.github.com>
Copilot finished work on behalf of
VividLemon
September 2, 2025 18:16
|
@copilot You need to add the new props to the .data.ts files in the documentation as it will not build properly without them |
Co-authored-by: VividLemon <31498096+VividLemon@users.noreply.github.com>
Added headerAttrs prop definitions to both modal.data.ts and offcanvas.data.ts documentation files. The build now works properly without any issues. Changes committed in 7fd6679. |
Copilot finished work on behalf of
VividLemon
September 3, 2025 18:25
|
Caution Review failedThe pull request is closed. WalkthroughAdds an optional headerAttrs prop to BModal and BOffcanvas, threads it through type definitions, components, and docs data, and binds it to the header elements. Introduces unit tests validating attribute passthrough, interaction with headerClass, absence when undefined, and noHeader behavior. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant App as App
participant Modal as BModal
participant DOM as DOM Header
App->>Modal: mount with { headerAttrs, headerClass, noHeader }
alt noHeader = true
Modal-->>App: do not render header
else noHeader = false
Modal->>DOM: render header with class + v-bind(headerAttrs)
Note right of DOM: Attributes from headerAttrs applied<br/>(e.g., id, data-*)
end
sequenceDiagram
autonumber
participant App as App
participant Offcanvas as BOffcanvas
participant DOM as DOM Header
App->>Offcanvas: mount with { headerAttrs, headerClass, noHeader }
alt noHeader = true
Offcanvas-->>App: do not render header
else
Offcanvas->>DOM: render header with class + v-bind(headerAttrs)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (7)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
VividLemon
approved these changes
Sep 3, 2025
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Summary by CodeRabbit