Skip to content

normalize stack traces #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thomasballinger opened this issue Dec 16, 2015 · 1 comment
Closed

normalize stack traces #591

thomasballinger opened this issue Dec 16, 2015 · 1 comment

Comments

@thomasballinger
Copy link
Member

#229 had the inadvertent effect of making terminal history unnecessarily inconsistent because each time a rewind happens, the input lines change:

(bpython)tomb@tom-mba (master) bpython$ bpython
bpython version 0.15.dev233 on top of Python 2.7.10 /Users/tomb/.virtualenvs/bpython/bin/python2.7
>>> import
  File "<bpython-input-2>", line 1
    import
         ^
SyntaxError: invalid syntax
>>> 1
1
>>>

becomes

(bpython)tomb@tom-mba (master) bpython$ bpython
bpython version 0.15.dev233 on top of Python 2.7.10 /Users/tomb/.virtualenvs/bpython/bin/python2.7
>>> import
  File "<bpython-input-4>", line 1
    import
         ^
SyntaxError: invalid syntax
>>>

It'd be nice to do one of the following, or something else I haven't thought of

  • line count should be reset on rewind
  • stack traces should be modified to remove these numbers
  • history inconsistency detection should ignore these differences
thomasballinger added a commit that referenced this issue Dec 16, 2015
@thomasballinger
fix #591 changing stack trace linenos
0cb8163
@thomasballinger
Copy link
Member Author

Whoops, inadvertently closed. This is waiting on #592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomasballinger