-
-
Notifications
You must be signed in to change notification settings - Fork 245
faulthandler stdlib module requires fileno on stdout #628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
It looks like this is due to import faulthandler
faulthandler.enable() Someone should look into what faulthandler and see what it wanted to do with fileno to see what we should do about it.
|
hi @thomasballinger , I am new to open source, would love to contribute |
@Kashyap12, great to hear, and welcome! Would you like to take a look at this issue? You can contact me at me@ballingt.com or on freenode in #bpython if you want to talk in depth about how to get started or you have questions, or you're welcome to ask them here; @goetzc can mute this thread if it gets long ;) The first thing you'll want to do is to try out bpython; it'll be helpful context for this issue. You can either pip install it, which would work well enough to start working on this issue, or you can follow these instructions to get a version of the source code that's easy to change on your machine. There are a few tasks I can think of for this issue:
Because faulthandler is part of the standard library, we should definitely try to find a solution that makes this work. I have some ideas (main one: making a new pipe that user Python code like this can write to that we'd combine with regular |
Hi @goetzc @thomasballinger , I tried to reproduce the same issue on my bpython set up, i.e. I got no error :) |
FWIW, with bpython upgraded to 0.16 (and maintaining Python at 3.5.2) I don't get the error :) |
@goetzc so is this issue closed? |
Oh great! It looks like this was fixed by #616. Thanks for digging into this more @Kashyap12, and thanks @goetzc for reporting and testing again! @Kashyap12, let me know if you're interested contributing more and would like suggestions for issues. bitesize would be a good place to start. |
Like issue #622, this one for 'fileno'.
The text was updated successfully, but these errors were encountered: