Skip to content

Fix #194 #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 4, 2014
Merged

Fix #194 #368

merged 6 commits into from
Sep 4, 2014

Conversation

mlauter
Copy link
Contributor

@mlauter mlauter commented Aug 30, 2014

Add some helpful highlighting to traceback and error messages rather than just printing a wall of red text.

@thomasballinger
Copy link
Member

This works for me, have you tried it with Python3?

Two comments for making the code easier to maintain in the future:could you add a testfor this (so we catch Python 2/3 problems automatically) and factor out the portions common to both the traceback and syntax error methods? (So we don't mess up by changing one but not the other, except for things that are different between them)

This reminds me of needing to get make sure future statements work alright with this interpreter, but that's not your problem - just a reminder for me because the old bpython interactive interpreter is doing fancier things than we do in bpython curtsies.

@mlauter
Copy link
Contributor Author

mlauter commented Sep 1, 2014

I haven't run into any problems using it with python 3. I'll make those other changes.

thomasballinger added a commit that referenced this pull request Sep 4, 2014
@thomasballinger thomasballinger merged commit 0513f1a into bpython:master Sep 4, 2014
@thomasballinger
Copy link
Member

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants