Show single underscore attributes before double underscore ones #528 #561
Conversation
| @@ -256,6 +256,7 @@ def matches(self, cursor_offset, line, **kwargs): | |||
| if not r.word.split('.')[-1].startswith('_'): | |||
| matches = set(match for match in matches | |||
| if not match.split('.')[-1].startswith('_')) | |||
| # MAYBE HERE 2 ?? | |||
There was a problem hiding this comment.
Looks like a few comments made it in by accident
| @@ -365,3 +367,6 @@ def func(apple, apricot, banana, carrot): | |||
| set(['banana='])) | |||
| self.assertSetEqual(com.matches(3, "car", argspec=argspec), | |||
| set(['carrot='])) | |||
|
|
|||
There was a problem hiding this comment.
Instead of this, you can run individual tests with nose tests/test_autocomplete.py
|
Also check out the tests, https://travis-ci.org/bpython/bpython/jobs/79684995 |
|
Looks great, thanks @wevial. I'll take a closer look today. Hope you're well! |
|
Ah I see - this is absolutely my fault, but because I didn't review this in time #568 was merged instead. That PR doesn't quite do what I requested in issue #528, it doesn't even show double underscore methods until the user adds the second underscore. But it does the basic idea, and it's maybe a better idea. @wevial this is great but looks like we don't need it. Thanks for submitting and doing the changes I asked for, sorry I didn't review it in time because I absolutely would have accepted it. |
Autocomplete shows single underscore attributes before double underscore ones, as per Tom's suggestion.