Fix fd encodings #629
Merged
Fix fd encodings #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given more activity on #622 I'll plan to look at merging this tomorrow. |
this is both more accurate and corrects the spelling from UTF8 to UTF-8
Start storing an original file object on the fake one.
8c920bd to
525e360
Compare
sebastinas
reviewed
Oct 11, 2020
| out = FakeOutput(mock.Mock(), self.assert_unicode) | ||
| out.write("native string type") | ||
| out = FakeOutput(mock.Mock(), self.assert_unicode, None) | ||
| out.write('native string type') |
There was a problem hiding this comment.
Please change it back to "" (or run black before merging the changes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose we provide
fileno()methods and.encodingproperties on fake file objects that replace sys.stdin/stdout/stderr. Applications may use them in ways that work or in ways that don't, but we should just provide them and see what happens.Pro: users can use more libraries with bpython
Con: code may break in less expected ways that the straightforward attribute errors they break on now, e.g. the display may break when a program writes directly to sys.stdout.fileno() because that won't be caught by bpython