Skip to content

Use width aware slice #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2017
Merged

Use width aware slice #684

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc9fbb4
Use width aware slice
May 10, 2017
c511845
Fix test failure
May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions bpython/curtsiesfrontend/replpainter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,15 @@ def display_linize(msg, columns, blank_line=False):
"""Returns lines obtained by splitting msg over multiple lines.

Warning: if msg is empty, returns an empty list of lines"""
display_lines = ([msg[start:end]
for start, end in zip(
range(0, len(msg), columns),
range(columns, len(msg) + columns, columns))]
if msg else ([''] if blank_line else []))
msg = fmtstr(msg)
try:
display_lines = ([msg.width_aware_slice(slice(start, end))
for start, end in zip(
range(0, msg.width, columns),
range(columns, msg.width + columns, columns))]
if msg else ([''] if blank_line else []))
except ValueError:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In which case do we get a ValueError here?

Copy link
Contributor Author

@ata2001 ata2001 May 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When attempting to get the width of a FmtStr, curtsies raises a ValueError, in case the length of the string is greater than 0, but the width of the FmtStr is less than 1.

https://raw.githubusercontent.com/thomasballinger/curtsies/master/curtsies/formatstring.py

At line 85.

display_lines = ['']
return display_lines


Expand Down