Fix newline handling in stdout and stderr #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastinas
reviewed
May 28, 2017
bpython/curtsiesfrontend/repl.py
Outdated
| def send_to_stdout(self, output): | ||
| """Send unicode string to Repl stdout""" | ||
| if not output: return |
There was a problem hiding this comment.
Please add break the line after :.
bpython/curtsiesfrontend/repl.py
Outdated
| @@ -1157,9 +1165,16 @@ def send_to_stderr(self, error): | |||
|
|
|||
| Must be able to handle FmtStrs because interpreter pass in | |||
| tracebacks already formatted.""" | |||
| if not error: return | |||
There was a problem hiding this comment.
Please add break the line after :.
bpython/curtsiesfrontend/repl.py
Outdated
| lines = output.split('\n') | ||
| if output == len(output) * '\n': | ||
| # If the string consist only of newline characters, | ||
| # str.split returns one more empty strings. |
There was a problem hiding this comment.
Since at this point split was already called, I'd feel that if all(len(line) == 0 for line in lines): would be nicer.
There was a problem hiding this comment.
What about if all(not line for line in lines):?
bpython/curtsiesfrontend/repl.py
Outdated
| if error == len(error) * '\n': | ||
| # If the string consist only of newline characters, | ||
| # str.split returns one more empty strings. | ||
| lines = lines[:-1] |
There was a problem hiding this comment.
Similar to the other splitcomment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #658.