fix encoding issues in urwid and curses #702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"bytes on python 2, unicode in python 3" is more easily referred to as "native str" :) |
|
Would be good to have test case so that we don't break that again in the future.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #701
Make it clear with comments that self.stdout_hist is bytes in Python 2, unicode in Python 3. Blech, would be nice to fix that to be unicode everywhere.
To debug I made self.stdout_hist a type-checking property, maybe this is worth doing for real? Also maybe static typechecking would be nice? But this PR just fixes this bug.