Skip to content

Respect locals when using embed() #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Respect locals when using embed() #895

merged 1 commit into from
Apr 20, 2021

Conversation

ocurero
Copy link
Contributor

@ocurero ocurero commented Apr 17, 2021

Fixes #841 while keeping the behaviour of #692 and #506.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021

Codecov Report

Merging #895 (32363dc) into master (8b728d9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #895   +/-   ##
=======================================
  Coverage   67.85%   67.85%           
=======================================
  Files          61       61           
  Lines        9153     9153           
=======================================
  Hits         6211     6211           
  Misses       2942     2942           
Impacted Files Coverage Δ
bpython/args.py 86.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b728d9...32363dc. Read the comment docs.

@sebastinas sebastinas merged commit bc1916b into bpython:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

embed() does not honor locals when a script is used
3 participants