Skip to content

Fixed bug with sys.stdin.readline() #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

IgorKorobeynikov
Copy link

image
I fixed this bug:
image

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2021

Codecov Report

Merging #909 (fadc1fb) into main (f7d8b77) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
- Coverage   67.93%   67.91%   -0.03%     
==========================================
  Files          61       61              
  Lines        9150     9153       +3     
==========================================
  Hits         6216     6216              
- Misses       2934     2937       +3     
Impacted Files Coverage Δ
bpython/curtsies.py 50.67% <0.00%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7d8b77...fadc1fb. Read the comment docs.

@sebastinas
Copy link
Contributor

I fear that this just hides an issue. self.current_stdouterr_line has the wrong time in this case and that should be fixed.

@thomasballinger thomasballinger self-assigned this Oct 7, 2021
thomasballinger added a commit that referenced this pull request Oct 7, 2021
Static types would have helped! I'll add some.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants