Skip to content

add typing-extensions requirement #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from

Conversation

dtrodrigues
Copy link
Contributor

resolves #938

@sebastinas sebastinas changed the base branch from main to 0.22-bugfix November 8, 2021 08:10
@sebastinas
Copy link
Contributor

Thank you. I've rebased and merged your PR on the 0.22-bufix branch. In main, we can get rid of typing_extensions since Python 3.6 support was removed.

@sebastinas sebastinas closed this Nov 8, 2021
@sebastinas
Copy link
Contributor

Ah, that won't work. Literal was only added in 3.8.

@thomasballinger
Copy link
Member

oof, sorry about introducing Literal, I should have left it as bool or whatever

@sebastinas
Copy link
Contributor

For __exit__, Literal[False] is actually recommended. So it's fine. 0.22.1 has been released to add the dependency on typeing_extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing typing_extensions dependency in 0.22 release
3 participants