allows passing through up-down/left-right borders on option #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brean
reviewed
Dec 19, 2019
| @@ -95,7 +101,7 @@ def neighbors(self, node, diagonal_movement=DiagonalMovement.never): | |||
| neighbors.append(self.nodes[y - 1][x]) | |||
| s0 = True | |||
| # → | |||
| if x == self.width and self.passable_left_right_border: | |||
| if x == self.width - 1 and self.passable_left_right_border: | |||
There was a problem hiding this comment.
Nice catch with the -1 (self.width is the length and we are accessing array indices, so this might raise an IndexError)! I think this bug was not seen before? Good bugfix.
There was a problem hiding this comment.
Think I made the bug myself and then fixed it :D Thanks anyway!
There was a problem hiding this comment.
Oh oups... Anyway, thanks for the pull request!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for the minor improvement suggested in issue #23.