Skip to content

Error object differs between pg and pg-native #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
deyhle opened this issue Feb 15, 2016 · 3 comments
Closed

Error object differs between pg and pg-native #938

deyhle opened this issue Feb 15, 2016 · 3 comments
Milestone
pg@7.0

Comments

@deyhle
Copy link

deyhle commented Feb 15, 2016

node-postgres abstracts over the pg-native module to provide exactly the same interface as the pure JavaScript version. No other code changes are required. If you find yourself having to change code other than the require statement when switching from require('pg') to require('pg').native please report an issue.

The fix for #743 made me test a switch to pg-native again. However, I still found an API difference: the Error object. While the default pg library returns an error with properties code and detail, the parameters are named differently when using pg-native.

require('pg'):

{
  "name": "error",
  "length": 199,
  "severity": "ERROR",
  "code": "23505",
  "detail": "Key (c1)=(one) already exists.",
  "schema": "public",
  "table": "dbhandlertest",
  "constraint": "dbhandlertest_pkey",
  "file": "nbtinsert.c",
  "line": "402",
  "routine": "_bt_check_unique"
}

require('pg').native:

{
  "severity": "ERROR",
  "sqlState": "23505",
  "messagePrimary": "duplicate key value violates unique constraint \"dbhandlertest_pkey\"",
  "messageDetail": "Key (c1)=(one) already exists.",
  "sourceFile": "nbtinsert.c",
  "sourceLine": "402",
  "sourceFunction": "_bt_check_unique"
}

This makes it hard to do proper error handling. Especially the code property is probably used a lot for that.
@abenhamdine abenhamdine mentioned this issue Feb 16, 2016
Closed
@kevinburkeshyp kevinburkeshyp mentioned this issue Mar 29, 2016
Closed
@vitaly-t vitaly-t mentioned this issue Apr 7, 2016
Closed
@brianc brianc added this to the pg@7.0 milestone Jun 6, 2017
@brianc
Copy link
Owner

brianc commented Jun 6, 2017

Adding to the pg@7.0 release milestone to normalize these fields across the native bindings & the pure javascript library.

@vitaly-t
Copy link
Contributor

vitaly-t commented Jun 6, 2017

This makes it hard to do proper error handling. Especially the code property is probably used a lot for that.

In the meantime, the generic error handler can simply accept the native flag and parse errors differently.

brianc added a commit that referenced this issue Jun 9, 2017
@brianc
Normalize native error properties
056f42c 
Map native error properties to the same property names we use for errors from the JS driver.

Fixes #972
Fixes #938
brianc added a commit that referenced this issue Jun 9, 2017
@brianc
Remove fallbacks for unsupported Node versions (#1304) (#1313)
aeb0c75 
* Add client connectionString tests (#1310)

* Remove redundant tests

* Add client connectionString test

Add test to ensure { connectionString } is respected as an argument to the client constructor

* Add test for connection string property

Also fixed some legacy require statements.

* Normalize native error properties

Map native error properties to the same property names we use for errors from the JS driver.

Fixes #972
Fixes #938
@brianc
Copy link
Owner

brianc commented Jun 9, 2017

I have this fixed on the 7.0 branch.

@brianc brianc closed this as completed Jun 9, 2017
brianc added a commit that referenced this issue Jun 9, 2017
@brianc
Remove fallbacks for unsupported Node versions (#1304) (#1313)
92a411f 
* Add client connectionString tests (#1310)

* Remove redundant tests

* Add client connectionString test

Add test to ensure { connectionString } is respected as an argument to the client constructor

* Add test for connection string property

Also fixed some legacy require statements.

* Normalize native error properties

Map native error properties to the same property names we use for errors from the JS driver.

Fixes #972
Fixes #938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
pg@7.0
Development

No branches or pull requests
3 participants
@brianc @deyhle @vitaly-t