Skip to content

Change test matrix in .travis.yml #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2016
Merged

Change test matrix in .travis.yml #1002

merged 3 commits into from
Apr 27, 2016

Conversation

brianc
Copy link
Owner

@brianc brianc commented Apr 27, 2016

Add tests for node @ v6. Remove node & postgres test permutations for older versions of node.

Add tests for node @ v6. Remove node & postgres test permutations for older versions of node.
@vitaly-t
Copy link
Contributor

vitaly-t commented Apr 27, 2016

You really should use Node.js versions as a single number everywhere: node_js: "4", node_js: "5", node_js: "6". That will guarantee the use of the latest sub-version.

@brianc
Copy link
Owner Author

brianc commented Apr 27, 2016

Ah that's good to know, thanks. I'll do that.

@vitaly-t
Copy link
Contributor

You missed one for the 4 ;) Current is 4.4, and you are testing under 4.1 ;)

@vitaly-t
Copy link
Contributor

vitaly-t commented Apr 27, 2016

Cheers! Once you're all done, please release the new one as 4.6.0 ;) So we will know it is the one that's supposed to work with Node.js 6.x properly ;)

@brianc
Copy link
Owner Author

brianc commented Apr 27, 2016

4.5.5 is supposed to work with node 6 properly - fixing a bug with how buffers were used does not warrant a new minor version bump & the minor version of this library never has indicated in any way which versions of node it was compatible with. Is there some way bumping the minor versus patch would help out?

@brianc brianc merged commit 5d3b506 into master Apr 27, 2016
@brianc brianc deleted the add-node-v6-to-travis branch June 8, 2017 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants