Handle "NULL" correctly in arrays #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NULL in arrays is NULL, but "NULL" in arrays is 'NULL' (a string).
brianc
added a commit
that referenced
this pull request
Mar 7, 2012
|
Thanks! I added a failing test before I merged your changes, merged them, and then the test passed...open source is magical |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NULL in arrays is NULL, but "NULL" in arrays is 'NULL' (a string).
Sorry about the lack of tests for this. I just noticed it as I was building a ruby PostgreSQL array
parser based on the code, and one of my tests wasn't working.