Fix ECONNRESET error emitted after failed connect #1230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, after a connect attempt has failed, an error event with ECONNRESET is emitted after the real connect error is propagated to the connect callback, because the connection is not in ending state (connection._ending) where ECONNRESET is ignored. This change ends the connection when connect has failed. This fixes brianc#746.
|
I used the following test script to see where the error came from: const pg = require('pg');
pg.on('error', err => {
throw new Error(`got error from pg: ${err}`);
});
pg.connect({
connectionString: 'postgres://postgres:wrongpassword@localhost/postgres',
log: console.log,
}, (err, client, done) => {
if (err) {
console.log(`pg.connect failed: ${err}`);
done(err);
return;
}
console.log(`pg.connect succeeded`);
done();
pg.end();
});and the output: The last frame (client.js:183) is called by connection error event handler (connection.js:71), and there self._ending is false at the time, so it's not ignoring the ECONNRESET error. |
|
Hey @magnushiie - thank you so much for putting this together! Is there any way you could include a test for this? To write a test just add a new file under this folder that has the issue number (1230) - the file should exit with a 0 status code to indicate the tests pass. This way we can be sure not to introduce regressions in the future! |
|
Actually, the test "raises error if cannot connect" in test/integration/client/api-tests.js already fails for me without this fix: With the fix: When it fails, it also fails the suite (when run via make): |
|
Ah nice thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, after a connect attempt has failed, an error event with
ECONNRESET is emitted after the real connect error is propagated to the
connect callback, because the connection is not in ending state
(connection._ending) where ECONNRESET is ignored. This change ends the
connection when connect has failed.
This fixes #746.