Skip to content

Conversation

Rich-Harris
Copy link
Contributor

Closes #1813

@sehrope
Copy link
Contributor

sehrope commented Jan 15, 2019

+1. Overall looks good but I'd changed the error message a bit. It's got a Unicode — (—) rather than regular dash ("-"). Also the reference to plural "queries" should be singular and it could be any type of statement.

How about:

Prepared statements must be unique - '${this.name}' was used for a different statement

@Rich-Harris
Copy link
Contributor Author

Thanks for taking a look — I've made that change

@brianc
Copy link
Owner

brianc commented Mar 6, 2019

Nice I'll release a new semver patch w/ this change ASAP! Sorry for the delay.

@brianc brianc merged commit e6a878c into brianc:master Mar 6, 2019
@Rich-Harris Rich-Harris deleted the unique-prepared-statements branch March 6, 2019 15:37
@Rich-Harris
Copy link
Contributor Author

excellent, thank you!

@brianc
Copy link
Owner

brianc commented Mar 7, 2019

published pg@7.8.2 - thanks again for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants