Add pg cursor #2030
Add pg cursor #2030
Conversation
Still have weird race conditions & shutdown/error/resume conditions to tackle
Work with queries that don't have row descriptions
Closes #6
Fix typo: itterate -> iterate
Fix named portal not closing
Add additional pool test & deprecate .end
Fix closing a finished cursor without supplying a callback
…into juneidysoo-master
Yep! It should definitely be merged with a merge commit. Looks like this isn’t based off of the latest master, though. |
latest master of pg-cursor? I think it is...? The most recent commit there is |
|
Latest master of pg, but I was misled by GitHub. Never mind :D |
|
uggg...I think I did something wrong - I'm not seeing all the commits in history here after a merge commit. |
|
@charmander think I should revert & try again? |
|
@brianc They’re there, just sorted by date. |
|
ah okay I checked this and only saw two commits, thought I did something wrong... https://github.com/brianc/node-postgres/commits/master/packages/pg-cursor/index.js Maybe it's just because the file move stuff got lost due to |
|
Yeah, that’s exactly it :( I actually thought there would be a rename involved that Git could follow, but it seems like it’s a special kind of merge commit instead. Maybe I’ve done this other times by rewriting the commits of the subtree repo to point to their new destinations… but that loses a different set of information too. Oh well – the history can be found by following the last commit in that list manually. |
|
😱 k thanks!!! |
This moves the entire history of the pg-cursor into the monorepo structure. I used
git subtreeto preserve every commit from the prior repo.@charmander is this what you had in mind w/ preserving history? You can optionally squash the exiting history, but I think it's nice to preserve it.
I had to update a few lint rules and change the formatting and linting on this module to bring it into conformance w/ the main repo lint rules. Once I get all the repos consolidated here I can do cross-cutting lint changes much more easily.
I haven't yet added
pgas a dependency topg-cursorand set up learn to manage the dependencies between them. This will be a semver major change forpg-cursorI think as it currently allows you to install it with any version ofpgwhich isn't good. Sincepg-cursorreaches into the internals ofpgin some places it'll be nice to lock-step these versions so changes can be easily coordinated between the two. I haven't researched yet exactly how to manage the versions so I'll research that a bit later.