Parser speed improvements #2151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the things that was causing slowdowns was using a transform stream to parse messages. Not a huge slowdown but the overhead of an additional event emitter versus a single callback. There is a lot more work to do here, but I am gonna merge this into master so we can get CI starting to work on the new code path to keep things from drifting again.
I also brought the new connection code in line w/ the existing code & changes from 8.0. Adding the new parsing code path to travis so I can ensure it works in all supported node versions.
I'll try to include my very, very crude benchmark numbers w/ PRs to track perf progress.