chore(pg-query-stream): remove through dependency #2518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9360e9 to
f124026
Compare
|
hey this is cool thank you! You're definitely welcome to look through anything else you think its worthwhile - always open to contribution! If it's an architecture or major change probably best to open an issue about it to discuss. My # 1 goal is being very very careful w/ backwards compatibility so those changes would be trickier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was browsing through the tests for the
pg-query-streampackage to see how to wire a transform stream to the output and the dependency seemed unnecessary to me. Hence this PR is removing it and replacing it with a stream.Transform.If you think changes like this are worthwhile I can have a look through the other packages for similar "easy" PRs to get started contributing to
pg.