Skip to content

Return promise on cursor end #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2021
Merged

Return promise on cursor end #2589

merged 2 commits into from
Jul 29, 2021

Conversation

brianc
Copy link
Owner

@brianc brianc commented Jul 29, 2021

Addresses one of the issues brought up in #2588

charmander
charmander approved these changes Jul 29, 2021
View reviewed changes
Copy link
Collaborator

@charmander charmander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s also a redundant if (cb) a little farther down.

@brianc
Copy link
Owner Author

brianc commented Jul 29, 2021

There’s also a redundant if (cb) a little farther down.

ty ❤️ ❤️

@brianc brianc merged commit 98cd59e into master Jul 29, 2021
@brianc brianc deleted the bmc/return-promise-on-cursor-end branch July 29, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charmander charmander charmander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brianc @charmander