perf: remove superfluous flush message #2842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ohhh nice - less network traffic is good, right!? 😄 Thanks for the writeup. Normally I need tests for changes but this change is tested already but almost every integration test in the project so we're good there! (existing tests do have to pass though) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-postgres sends both a
Flushand aSyncmessage at the end of an extended protocol query protocol session. This is not necessary, asSyncalready implicitly includesFlush.Flushwill cause the backend to flush its network buffers and return any pending responses to the client.Syncwill do the same, but also commit the implicit transaction (if any) and the backend will respond with aReadyForQuerymessage. Removing this extra step will save one network message for each extended query protocol session that is executed.We noticed this behavior while testing the node-postgres driver with our proxy that allows Cloud Spanner to be used with PostgreSQL drivers.