Skip to content

feat: add connection parameter nativeConnectionString #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2023

Conversation

NovikovEvgeny
Copy link
Contributor

@NovikovEvgeny NovikovEvgeny commented Mar 29, 2023

This is a follow-up of MR #2751

I copy-pasted the solution itself, but also I have added tests as you asked

Support of nativeConnectionString in some cases could be really useful like

  • specifying multihost URI
  • specifying additional params (like target_session_attrs)
  • having different formats of the connection URI, anything what is described in the libpq docs

using ConnectionParameters class not always be helpful since it doesn't support all possible variants of the connection string

@alexkvak
Copy link

@brianc here is the same as #2751 but with tests. Could you review and merge it?

@brianc
Copy link
Owner

brianc commented May 31, 2023

Nice! Thanks - sorry for the delay. Will release this today. 😄

@brianc brianc merged commit dee3ae5 into brianc:master May 31, 2023
@alexkvak
Copy link

alexkvak commented Jun 5, 2023

Could you release this feature? @brianc

thijs pushed a commit to thijs/node-postgres that referenced this pull request Aug 1, 2023
Co-authored-by: Evgeniy Novikov <e.p.novikov@tinkoff.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants