Fix hangs when connection drops or exception is thrown from query callback #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hang when connection drops after submitting query
|
can you write tests for this? |
|
Sure. |
|
💃 |
|
Wonder if this should be a client error as well, or maybe both? I think that the client's dead after the socket ends. |
|
We may actually be running into this very issue. Will be looking forward to testing with this. |
|
Any updates on this? I believe we could be running into same issue. |
|
I just need to get a test written for this before I merge it. Haven't had time to work on this in a while, will try to get to it tonight or tomorrow. |
|
I fixed this in pull #315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.