Skip to content

#701 Expose error fields added in PG 9.3. #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2015
Merged

Conversation

rpedela
Copy link
Contributor

@rpedela rpedela commented Jan 10, 2015

Several error fields were added in PG 9.3:

  • schema
  • table
  • column
  • data type
  • constraint

This PR exposes them in the returned Error object.

@brianc
Copy link
Owner

brianc commented Jan 12, 2015

@rpedela thank you so much! Quick question...is there any way you could write a test for this? I know it's postgres version dependent...you could use this function to only run the test if the database version supports it. Here's an example

@rpedela
Copy link
Contributor Author

rpedela commented Jan 12, 2015

Tests added. I am not sure how to trigger the "data type" error field, but the others are tested. I am happy to add another test for the "data type" error field if someone knows how to trigger it.

@brianc
Copy link
Owner

brianc commented Jan 13, 2015

@rpedela awesome! 👏 💃

Will push a new minor version with this change later today. 👍

brianc added a commit that referenced this pull request Jan 13, 2015
#701 Expose error fields added in PG 9.3.
@brianc brianc merged commit ba84f30 into brianc:master Jan 13, 2015
@rpedela
Copy link
Contributor Author

rpedela commented Jan 14, 2015

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants