feature symfony#52720 [Cache] Remove database server version detection (derrabus)

derrabus · derrabus · commit 37926c888fc4 · 2023-11-25T21:22:00.000+01:00
This PR was merged into the 7.0 branch. Discussion ---------- [Cache] Remove database server version detection | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | N/A | License | MIT Our DoctrineDbalAdapter is currently sniffing for the database server version to implement workarounds for very old database servers: * SQL Server before 2008: DBAL 3 does not support older SQL server releases than this one. * Postgres before 9.5: Postgres 9.5 has been released in Jan 2016, it predecessor 9.4 is EOL since Feb 2020. I think it's fair to not support those old releases anymore at this point. Commits ------- 842c3c2 [Cache] Remove database server version detection
diff --git a/UPGRADE-7.0.md b/UPGRADE-7.0.md
@@ -54,6 +54,7 @@ Cache
 -----
 
  * Add parameter `\Closure $isSameDatabase` to `DoctrineDbalAdapter::configureSchema()`
+ * Drop support for Postgres < 9.5 and SQL Server < 2008 in `DoctrineDbalAdapter`
 
 Config
 ------
diff --git a/src/Symfony/Component/Cache/Adapter/DoctrineDbalAdapter.php b/src/Symfony/Component/Cache/Adapter/DoctrineDbalAdapter.php
@@ -14,14 +14,12 @@
 use Doctrine\DBAL\ArrayParameterType;
 use Doctrine\DBAL\Configuration;
 use Doctrine\DBAL\Connection;
-use Doctrine\DBAL\Driver\ServerInfoAwareConnection;
 use Doctrine\DBAL\DriverManager;
 use Doctrine\DBAL\Exception as DBALException;
 use Doctrine\DBAL\Exception\TableNotFoundException;
 use Doctrine\DBAL\ParameterType;
 use Doctrine\DBAL\Schema\DefaultSchemaManagerFactory;
 use Doctrine\DBAL\Schema\Schema;
-use Doctrine\DBAL\ServerVersionProvider;
 use Doctrine\DBAL\Tools\DsnParser;
 use Symfony\Component\Cache\Exception\InvalidArgumentException;
 use Symfony\Component\Cache\Marshaller\DefaultMarshaller;
@@ -35,7 +33,6 @@ class DoctrineDbalAdapter extends AbstractAdapter implements PruneableInterface
     private MarshallerInterface $marshaller;
     private Connection $conn;
     private string $platformName;
-    private string $serverVersion;
     private string $table = 'cache_items';
     private string $idCol = 'item_id';
     private string $dataCol = 'item_data';
@@ -236,27 +233,27 @@ protected function doSave(array $values, int $lifetime): array|bool
         $platformName = $this->getPlatformName();
         $insertSql = "INSERT INTO $this->table ($this->idCol, $this->dataCol, $this->lifetimeCol, $this->timeCol) VALUES (?, ?, ?, ?)";
 
-        switch (true) {
-            case 'mysql' === $platformName:
+        switch ($platformName) {
+            case 'mysql':
                 $sql = $insertSql." ON DUPLICATE KEY UPDATE $this->dataCol = VALUES($this->dataCol), $this->lifetimeCol = VALUES($this->lifetimeCol), $this->timeCol = VALUES($this->timeCol)";
                 break;
-            case 'oci' === $platformName:
+            case 'oci':
                 // DUAL is Oracle specific dummy table
                 $sql = "MERGE INTO $this->table USING DUAL ON ($this->idCol = ?) ".
                     "WHEN NOT MATCHED THEN INSERT ($this->idCol, $this->dataCol, $this->lifetimeCol, $this->timeCol) VALUES (?, ?, ?, ?) ".
                     "WHEN MATCHED THEN UPDATE SET $this->dataCol = ?, $this->lifetimeCol = ?, $this->timeCol = ?";
                 break;
-            case 'sqlsrv' === $platformName && version_compare($this->getServerVersion(), '10', '>='):
+            case 'sqlsrv':
                 // MERGE is only available since SQL Server 2008 and must be terminated by semicolon
                 // It also requires HOLDLOCK according to http://weblogs.sqlteam.com/dang/archive/2009/01/31/UPSERT-Race-Condition-With-MERGE.aspx
                 $sql = "MERGE INTO $this->table WITH (HOLDLOCK) USING (SELECT 1 AS dummy) AS src ON ($this->idCol = ?) ".
                     "WHEN NOT MATCHED THEN INSERT ($this->idCol, $this->dataCol, $this->lifetimeCol, $this->timeCol) VALUES (?, ?, ?, ?) ".
                     "WHEN MATCHED THEN UPDATE SET $this->dataCol = ?, $this->lifetimeCol = ?, $this->timeCol = ?;";
                 break;
-            case 'sqlite' === $platformName:
+            case 'sqlite':
                 $sql = 'INSERT OR REPLACE'.substr($insertSql, 6);
                 break;
-            case 'pgsql' === $platformName && version_compare($this->getServerVersion(), '9.5', '>='):
+            case 'pgsql':
                 $sql = $insertSql." ON CONFLICT ($this->idCol) DO UPDATE SET ($this->dataCol, $this->lifetimeCol, $this->timeCol) = (EXCLUDED.$this->dataCol, EXCLUDED.$this->lifetimeCol, EXCLUDED.$this->timeCol)";
                 break;
             default:
@@ -366,22 +363,6 @@ private function getPlatformName(): string
         };
     }
 
-    private function getServerVersion(): string
-    {
-        if (isset($this->serverVersion)) {
-            return $this->serverVersion;
-        }
-
-        if ($this->conn instanceof ServerVersionProvider || $this->conn instanceof ServerInfoAwareConnection) {
-            return $this->serverVersion = $this->conn->getServerVersion();
-        }
-
-        // The condition should be removed once support for DBAL <3.3 is dropped
-        $conn = method_exists($this->conn, 'getNativeConnection') ? $this->conn->getNativeConnection() : $this->conn->getWrappedConnection();
-
-        return $this->serverVersion = $conn->getAttribute(\PDO::ATTR_SERVER_VERSION);
-    }
-
     private function addTableToSchema(Schema $schema): void
     {
         $types = [
diff --git a/src/Symfony/Component/Cache/CHANGELOG.md b/src/Symfony/Component/Cache/CHANGELOG.md
@@ -5,6 +5,7 @@ CHANGELOG
 ---
 
  * Add parameter `$isSameDatabase` to `DoctrineDbalAdapter::configureSchema()`
+ * Drop support for Postgres < 9.5 and SQL Server < 2008 in `DoctrineDbalAdapter`
 
 6.4
 ---
