[Cache] Remove database server version detection #52720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
bc3a79f to
5410fd8
Compare
|
What will be the behavior if someone uses an old version of Postgres? This should be mentioned in the changelog and the minimum database server versions needs to be documented. |
The adapter will use an SQL syntax the server won't understand. That's a hard exception.
I'll update the change log and open a PR for the docs. |
5410fd8 to
c5f7cd5
Compare
c5f7cd5 to
842c3c2
Compare
nicolas-grekas
approved these changes
Nov 25, 2023
|
I've opened symfony/symfony-docs#19187 for the docs. |
xabbuh
approved these changes
Nov 25, 2023
GromNaN
approved these changes
Nov 25, 2023
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 1, 2023
This PR was merged into the 7.0 branch. Discussion ---------- Document requirements for DoctrineDbalAdapter Follows symfony/symfony#52720. I've added a block that documents the compatibility with various database engines. * MySQL 5.7 is the oldest release supported by DBAL 3. * MariaDB 10.2 is the oldest release supported by DBAL 3. * The `MERGE` statement that the adapter uses requires Oracle 10g or newer. * SQL Server 2012 is the oldest release supported by DBAL 3. * The `INSERT OR REPLACE` statement that we use on SQLite requires PHP to be linked against libsqlite 3.24 or newer. * The `ON CONFLICT` clause that we use on Postgres was introduced with version 9.5. Commits ------- 4127633 Document requirements for DoctrineDbalAdapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our DoctrineDbalAdapter is currently sniffing for the database server version to implement workarounds for very old database servers:
I think it's fair to not support those old releases anymore at this point.