[Config] Fix for signatures of typed properties

tvandervorm · fabpot · commit bad2a2c87ac5 · 2019-07-15T08:55:28.000+02:00
diff --git a/src/Symfony/Component/Config/Resource/ReflectionClassResource.php b/src/Symfony/Component/Config/Resource/ReflectionClassResource.php
@@ -140,7 +140,7 @@ private function generateSignature(\ReflectionClass $class)
 
             foreach ($class->getProperties(\ReflectionProperty::IS_PUBLIC | \ReflectionProperty::IS_PROTECTED) as $p) {
                 yield $p->getDocComment().$p;
-                yield print_r($defaults[$p->name], true);
+                yield print_r($defaults[$p->name] ?? null, true);
             }
         }
 
diff --git a/src/Symfony/Component/Config/Tests/Resource/ReflectionClassResourceTest.php b/src/Symfony/Component/Config/Tests/Resource/ReflectionClassResourceTest.php
@@ -137,6 +137,14 @@ public function provideHashedSignature()
         yield [1, 13, 'protected function prot($a = [123]) {}'];
         yield [0, 14, '/** priv docblock */'];
         yield [0, 15, ''];
+
+        if (\PHP_VERSION_ID >= 70400) {
+            // PHP7.4 typed properties without default value are
+            // undefined, make sure this doesn't throw an error
+            yield [1, 5, 'public array $pub;'];
+            yield [0, 7, 'protected int $prot;'];
+            yield [0, 9, 'private string $priv;'];
+        }
     }
 
     public function testEventSubscriber()

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ private function generateSignature(\ReflectionClass $class)`
`140`	`140`
`141`	`141`	`foreach ($class->getProperties(\ReflectionProperty::IS_PUBLIC \| \ReflectionProperty::IS_PROTECTED) as $p) {`
`142`	`142`	`yield $p->getDocComment().$p;`
`143`		`- yield print_r($defaults[$p->name], true);`
	`143`	`+ yield print_r($defaults[$p->name] ?? null, true);`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`