minor symfony#52334 [Yaml] Inline::parse(null) not allowed (GromNaN)

fabpot · fabpot · commit bb5d49c16585 · 2023-10-28T16:31:54.000-07:00
This PR was merged into the 6.4 branch. Discussion ---------- [Yaml] `Inline::parse(null)` not allowed | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix symfony#52326 | License | MIT It's only called with string values in the Yaml component. This class is internal. It allows to change the arg type. The arg type was documented as `string`. symfony@7b1715b#diff-1d97fcfb29e99f0200c3952e9a1a11c4b9f825c0f5ad4d4515b9b1805f8c988eR47 Commits ------- 834e0ab Passing null to Inline::parse is not allowed
diff --git a/src/Symfony/Component/Yaml/Inline.php b/src/Symfony/Component/Yaml/Inline.php
@@ -55,7 +55,7 @@ public static function initialize(int $flags, int $parsedLineNumber = null, stri
      *
      * @throws ParseException
      */
-    public static function parse(string $value = null, int $flags = 0, array &$references = []): mixed
+    public static function parse(string $value, int $flags = 0, array &$references = []): mixed
     {
         if (null === $value) {
             return '';
diff --git a/src/Symfony/Component/Yaml/Tests/InlineTest.php b/src/Symfony/Component/Yaml/Tests/InlineTest.php
@@ -29,7 +29,7 @@ protected function setUp(): void
     /**
      * @dataProvider getTestsForParse
      */
-    public function testParse($yaml, $value, $flags = 0)
+    public function testParse(string $yaml, $value, $flags = 0)
     {
         $this->assertSame($value, Inline::parse($yaml, $flags), sprintf('::parse() converts an inline YAML to a PHP structure (%s)', $yaml));
     }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public static function initialize(int $flags, int $parsedLineNumber = null, stri`
`55`	`55`	`*`
`56`	`56`	`* @throws ParseException`
`57`	`57`	`*/`
`58`		`- public static function parse(string $value = null, int $flags = 0, array &$references = []): mixed`
	`58`	`+ public static function parse(string $value, int $flags = 0, array &$references = []): mixed`
`59`	`59`	`{`
`60`	`60`	`if (null === $value) {`
`61`	`61`	`return '';`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ protected function setUp(): void`
`29`	`29`	`/**`
`30`	`30`	`* @dataProvider getTestsForParse`
`31`	`31`	`*/`
`32`		`- public function testParse($yaml, $value, $flags = 0)`
	`32`	`+ public function testParse(string $yaml, $value, $flags = 0)`
`33`	`33`	`{`
`34`	`34`	`$this->assertSame($value, Inline::parse($yaml, $flags), sprintf('::parse() converts an inline YAML to a PHP structure (%s)', $yaml));`
`35`	`35`	`}`