minor symfony#52335 [Lock] Fix mongodb extension requirement in tests (GromNaN)

fabpot · fabpot · commit d311b21b5530 · 2023-10-28T16:35:17.000-07:00
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Lock] Fix mongodb extension requirement in tests | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT The MongoDB session store relies on `ext-mongodb`, not the legacy `ext-mongo`. Fix the PhpUnit requirement so the tests are not skipped: https://github.com/symfony/symfony/actions/runs/6668689428/job/18124800680#step:7:559 Commits ------- f9029cf [Lock] Fix mongodb extension requirement in tests
diff --git a/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MongoDbSessionHandlerTest.php b/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler/MongoDbSessionHandlerTest.php
@@ -13,6 +13,7 @@
 
 use MongoDB\Client;
 use PHPUnit\Framework\MockObject\MockObject;
+use PHPUnit\Framework\SkippedTestSuiteError;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\HttpFoundation\Session\Storage\Handler\MongoDbSessionHandler;
 
@@ -32,13 +33,16 @@ class MongoDbSessionHandlerTest extends TestCase
     private $storage;
     public $options;
 
-    protected function setUp(): void
+    public static function setUpBeforeClass(): void
     {
-        parent::setUp();
-
         if (!class_exists(Client::class)) {
-            $this->markTestSkipped('The mongodb/mongodb package is required.');
+            throw new SkippedTestSuiteError('The mongodb/mongodb package is required.');
         }
+    }
+
+    protected function setUp(): void
+    {
+        parent::setUp();
 
         $this->mongo = $this->getMockBuilder(Client::class)
             ->disableOriginalConstructor()
diff --git a/src/Symfony/Component/Lock/Tests/Store/MongoDbStoreFactoryTest.php b/src/Symfony/Component/Lock/Tests/Store/MongoDbStoreFactoryTest.php
@@ -11,20 +11,30 @@
 
 namespace Symfony\Component\Lock\Tests\Store;
 
+use MongoDB\Collection;
+use MongoDB\Client;
+use PHPUnit\Framework\SkippedTestSuiteError;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\Lock\Store\MongoDbStore;
 use Symfony\Component\Lock\Store\StoreFactory;
 
 /**
  * @author Alexandre Daubois <alex.daubois@gmail.com>
  *
- * @requires extension mongo
+ * @requires extension mongodb
  */
 class MongoDbStoreFactoryTest extends TestCase
 {
+    public static function setupBeforeClass(): void
+    {
+        if (!class_exists(Client::class)) {
+            throw new SkippedTestSuiteError('The mongodb/mongodb package is required.');
+        }
+    }
+
     public function testCreateMongoDbCollectionStore()
     {
-        $store = StoreFactory::createStore($this->createMock(\MongoDB\Collection::class));
+        $store = StoreFactory::createStore($this->createMock(Collection::class));
 
         $this->assertInstanceOf(MongoDbStore::class, $store);
     }
diff --git a/src/Symfony/Component/Lock/Tests/Store/MongoDbStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/MongoDbStoreTest.php
@@ -32,7 +32,7 @@ class MongoDbStoreTest extends AbstractStoreTestCase
 
     public static function setupBeforeClass(): void
     {
-        if (!class_exists(\MongoDB\Client::class)) {
+        if (!class_exists(Client::class)) {
             throw new SkippedTestSuiteError('The mongodb/mongodb package is required.');
         }
 

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ class MongoDbStoreTest extends AbstractStoreTestCase`
`32`	`32`
`33`	`33`	`public static function setupBeforeClass(): void`
`34`	`34`	`{`
`35`		`- if (!class_exists(\MongoDB\Client::class)) {`
	`35`	`+ if (!class_exists(Client::class)) {`
`36`	`36`	`throw new SkippedTestSuiteError('The mongodb/mongodb package is required.');`
`37`	`37`	`}`
`38`	`38`