Skip to content

CI/CD: Set Target macOS to 14.0 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025
Merged

CI/CD: Set Target macOS to 14.0 #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ wheel.expand-macos-universal-tags = true
build-dir = "build"
cmake.build-type = "Release"
cmake.args = ["-G", "Ninja"]
cmake.define = { CMAKE_OSX_DEPLOYMENT_TARGET = "15.0" }
cmake.define = { CMAKE_OSX_DEPLOYMENT_TARGET = "14.0" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While setting CMAKE_OSX_DEPLOYMENT_TARGET here is correct for local builds using scikit-build, there's a conflicting configuration for cibuildwheel in this same file that will likely override this setting during the CI build process.

On line 83, MACOSX_DEPLOYMENT_TARGET is still set to 15.0:

83: environment = { LCS_BUILD_DIR = "{project}/src/libCacheSim/build", MACOSX_DEPLOYMENT_TARGET = "15.0" }

The MACOSX_DEPLOYMENT_TARGET environment variable set by cibuildwheel will take precedence, and the wheels produced by the CI will still target macOS 15.0. This would defeat the purpose of this pull request.

To ensure the change is effective for the distributed wheels, please update line 83 to be consistent with this change.

cmake.version = ">=3.15"
cmake.source-dir = "."
install.strip = false
Expand Down