Set up pyproject.toml and Add Python project setup with protobuf generation #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemort
approved these changes
Jul 31, 2025
| "Topic :: System :: Distributed Computing", | ||
| ] | ||
| requires-python = ">=3.11,<3.12" | ||
| dependencies = [ |
There was a problem hiding this comment.
I plan to trim the dependency later since it's quite a demanding operation
pyproject.toml
Outdated
| packages = ["cadence", "cadence.shared"] | ||
|
|
||
| [tool.setuptools.package-data] | ||
| "*" = ["*.proto", "*.thrift"] |
There was a problem hiding this comment.
I don't know what this does but I hope we don't need thrift.
There was a problem hiding this comment.
cursor added that since idl have thrift files. But we can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Generated protobuf files: Complete set of Python protobuf bindings in
shared/uber/cadence/structureAdded automatic download of protoc 29.1 to .bin/ directory
Fixed protobuf runtime version mismatch by pinning to protobuf==5.29.1
Why?
We need the generated python files to ensure the communication is sync with server
How did you test it?
Only generated files
Potential risks
Release notes
Documentation Changes