Skip to content

Run testsuite on PHP 8.4 #17740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Run testsuite on PHP 8.4 #17740

merged 5 commits into from
Aug 22, 2024

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Jul 13, 2024

No description provided.

@ADmad ADmad added this to the 5.0.10 milestone Jul 13, 2024
@ADmad ADmad force-pushed the ci-php-8.4 branch 3 times, most recently from bf666e0 to b14e1b6 Compare July 13, 2024 08:27
@ADmad ADmad marked this pull request as draft July 13, 2024 08:29
@ADmad
Copy link
Member Author

ADmad commented Jul 13, 2024

Fatal error: Declaration of Cake\Chronos\Chronos::createFromTimestamp(int $timestamp, DateTimeZone|string|null $timezone = null): static must be compatible with DateTimeImmutable::createFromTimestamp(int|float $timestamp): static in /home/runner/work/cakephp/cakephp/vendor/cakephp/chronos/src/Chronos.php on line 743

Woot, they added a new method to the interface in 8.4?

@ADmad
Copy link
Member Author

ADmad commented Jul 13, 2024

Woot, they added a new method to the interface in 8.4?

php/php-src#12413

Great, so we will need to make a breaking change in Chronos for 8.4 compatibility.

@othercorey
Copy link
Member

The risk of extending PHP classes although this is a very rare change.

@ADmad ADmad changed the base branch from 5.x to 5.next July 13, 2024 14:10
@ADmad
Copy link
Member Author

ADmad commented Jul 13, 2024

/home/runner/work/_temp/44f45290-edee-4698-9f8b-a3393e518a01.sh: line 14: 3276 Segmentation fault (core dumped) vendor/bin/phpunit

Need help with this :)

@ADmad
Copy link
Member Author

ADmad commented Jul 13, 2024

Yay, only 1 error.

1) Cake\Test\TestCase\I18n\Formatter\IcuFormatterTest::testBadMessageFormat
Failed asserting that exception of type "Exception" is thrown.

@ADmad
Copy link
Member Author

ADmad commented Jul 16, 2024

Welp, now it's failing at composer install itself

Error: Composer\Platform\Runtime::invoke(): Argument #1 ($callable) must be of type callable, array given, called in phar:///usr/local/bin/composer/src/Composer/Repository/PlatformRepository.php on line 341

@othercorey
Copy link
Member

Welp, now it's failing at composer install itself

Error: Composer\Platform\Runtime::invoke(): Argument #1 ($callable) must be of type callable, array given, called in phar:///usr/local/bin/composer/src/Composer/Repository/PlatformRepository.php on line 341

I didn't see any 8.4 upgrade notes about callable type changes.

@ADmad
Copy link
Member Author

ADmad commented Jul 20, 2024

I have opened an issue with composer about the error.

@markstory markstory modified the milestones: 5.0.10, 5.0.11 Jul 28, 2024
Base automatically changed from 5.next to 6.x August 12, 2024 10:46
@LordSimal LordSimal changed the base branch from 6.x to 5.next August 12, 2024 10:57
@ADmad ADmad force-pushed the ci-php-8.4 branch 2 times, most recently from 74c7442 to 135def7 Compare August 20, 2024 02:29
@ADmad ADmad marked this pull request as ready for review August 21, 2024 16:33
@ADmad ADmad modified the milestones: 5.0.11, 5.1.0 Aug 21, 2024
@ADmad ADmad merged commit c677e67 into 5.next Aug 22, 2024
13 checks passed
@ADmad ADmad deleted the ci-php-8.4 branch August 22, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants