-
Notifications
You must be signed in to change notification settings - Fork 10.2k
feat: added custom classnames to event-assignment tab atom #17527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/07/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (11/07/24)1 reviewer was added to this PR based on Keith Williams's automation. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
We have:
There are 2 switch containers and I don't know which one refers to what also given that there is "enableWeightsToggle". is it possible to bring top level "switchContainer" into the switch itself aka:
i don't know if what i am saying makes sense, but I find |
turbo.json
Outdated
@@ -461,6 +461,7 @@ | |||
"NEXT_PUBLIC_POSTHOG_KEY", | |||
"NEXT_PUBLIC_POSTHOG_HOST", | |||
"VAPID_PRIVATE_KEY", | |||
"HUDDLE01_API_TOKEN" | |||
"HUDDLE01_API_TOKEN", | |||
"REPLEXICA_API_KEY" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed a TypeScript error from an empty arrow function by adding return.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have assingAllTeamMembersToggle
that has switchContainer
- we can rename it to assingAllTeamMembersSwitch
to have 1 word to describe concept and then what do you think about having assingAllTeamMembersSwitch.switchContainer
simply as assingAllTeamMembersSwitch.container
?
This also is for other PRs where we use toggle and switch - we just need to stick with 1 in a structure thats easy to understand.
assingAllTeamMembersToggle -> assingAllTeamMembers enableWeightsToggle -> enableWeights assingAllTeamMembersToggle -> assingAllTeamMembers
What does this PR do?
This PR introduces customizable class names (customClassnames) for the Event Type assignment page in the project. This addition allows developers to style specific elements of the Event Type assignment page
NOTE
assignment tab is only available for team events
Below is a full list of available custom class names with default styling:
Screenshot of Changes
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist