feat: refactor the pipedrive crm from revert to original pipedrive #17672
Conversation
|
@rajesh-jonnalagadda is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/15/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (11/15/24)1 label was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (11/16/24)1 reviewer was added to this PR based on Keith Williams's automation. |
…m:rajeshj11/cal.com into feat-16797-refactor-pipedrive-integration
chore: revert back the base url chore: minor api config changes chore: fix contact payload issue
f722361 to
e3669b2
Compare
|
Hey @rajesh-jonnalagadda , can you attach a loom for your solution? |
Ack |
|
@Praashh added the demo. please check |
|
I’m mainly interested in the experience and having the work on my GitHub. I’m happy to collaborate in a way that aligns with that and supports both our goals. I'm not particuarily interested with the reward. |
There was a problem hiding this comment.
Unit Tests are failing, @rajesh-jonnalagadda can you please fix this 🙏
@Praashh Apologies, I'm currently in the middle of a hackathon and won't be able to address this right now. Thank you for your understanding! |
|
This PR is being marked as stale due to inactivity. |
|
@rajesh-jonnalagadda could you pls fix the conflicts? |
| async function getAppKeysFromSlug(slug: string, enabled?: boolean) { | ||
| let where = { | ||
| slug, | ||
| } as Prisma.AppWhereUniqueInput; | ||
| if (enabled) { | ||
| where = { ...where, enabled: true }; | ||
| } | ||
| const app = await prisma.app.findUnique({ where: where }); |
There was a problem hiding this comment.
Why we made changes here?
| const baseData = { | ||
| type: appData.type, | ||
| key: key || {}, | ||
| appId: appData.appId, | ||
| ...(state?.teamId ? { teamId: state.teamId } : { userId }), | ||
| }; | ||
|
|
||
| const credentialId = (state?.credentialId || -1) as number; | ||
|
|
||
| await prisma.credential.upsert({ | ||
| where: { id: credentialId }, // Use a dummy ID if not upgrading | ||
| create: baseData, | ||
| update: baseData, |
| export interface PipedriveEvent { | ||
| id: string; | ||
| company_id: string; | ||
| user_id: string; | ||
| done: boolean; | ||
| type: string; | ||
| reference_type: string; | ||
| reference_id: string; | ||
| conference_meeting_client: string; | ||
| conference_meeting_url: string; | ||
| conference_meeting_id: string; | ||
| due_date: string; | ||
| due_time: string; | ||
| duration: string; | ||
| busy_flag: boolean; | ||
| add_time: string; | ||
| marked_as_done_time: string; | ||
| last_notification_time: Date; | ||
| last_notification_user_id: string; | ||
| notification_language_id: string; | ||
| subject: string; | ||
| public_description: string; | ||
| calendar_sync_include_context: string; |
There was a problem hiding this comment.
Isn't there any way we can shorten it? Do we need all of this?
|
@rajesh-jonnalagadda pls fix the conflicts. Also few tests are failing |
|
@rajesh-jonnalagadda please feel free to re-open this, closing as its stale now. |
|
@rajesh-jonnalagadda thanks for your work. But going with this one:- #22492 |
What does this PR do?
/claim Native Pipedrive integration #16797
https://www.loom.com/share/6147b80f849d4afb8e4882b3d380a5f8
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist