-
Notifications
You must be signed in to change notification settings - Fork 10.2k
chore: Upgrade prisma to 6.7.0 #21264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Omar López <zomars@me.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 2 issues across 20 files. Review them in mrge.io
id: userId, | ||
}, | ||
...userSelect, | ||
return await prisma.user.findUniqueOrThrow({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary use of await in return statement.
@@ -80,7 +102,7 @@ | |||
if (!users.length && this.eventType.userId) { | |||
const eventTypeUser = await this.getUserById(this.eventType.userId); | |||
if (!eventTypeUser) { | |||
throw new Error("buildUsersFromINnerClass.eventTypeUser.notFound"); | |||
throw new Error("buildUsersFromInnerClass.eventTypeUser.notFound"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed typo in error message from 'buildUsersFromINnerClass' to 'buildUsersFromInnerClass'.
d3c82d2
to
a1d2e30
Compare
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Signed-off-by: Omar López <zomars@me.com>
Signed-off-by: Omar López <zomars@me.com>
cb7b342
to
41a1ea9
Compare
This PR is being marked as stale due to inactivity. |
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
What does this PR do?
Upgades Prisma to version 6.7.0.
Most of the changes are only imports:
Some notable changes are:
What do we get from upgrading?
Ability to join queries
Ability to get typed raw sql queries
It opens up the door for data residency with multiple clients
Allows us to to try the new TypeScript first
prisma-client
generator which should be faster for dev. To be done in a follow up.Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by mrge
Upgraded Prisma and @prisma/client to version 6.7.0, updated the Prisma schema, and refactored user type usage for better type safety and compatibility.
Dependencies
Refactors
Prisma.UserArgs
withPrisma.UserSelect
across the codebase.