Skip to content

fix: replace routingFormResponse with routingFormResponseDenormalized #21297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

fix: replace routingFormResponse with routingFormResponseDenormalized #21297

wants to merge 9 commits into from

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented May 14, 2025 •
edited
Loading

What does this PR do?

This PR replaces RoutingFormReponse view with RoutingFormResponseDenormalized table.

In order to do that, I'm replacing the view usage and the filter logic with InsightsRoutingService. Now we the service is the unified interface to get data for both the table and the metrics for charts.

This PR also adds "attendee" filter to the /insights/routing table.

  • make sure attendee filter works well (name, email, phone)
  • Fixes CAL-5755

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

Summary by mrge

Switched insights routing data to use the new RoutingFormResponseDenormalized table for better performance and simpler queries.

  • Refactors
    • Updated server logic and types to fetch and filter data from RoutingFormResponseDenormalized.
    • Adjusted components and hooks to match the new data structure.

@linear Linear
Copy link

linear bot commented May 14, 2025

CAL-5755 Use RoutingFormResponseDenormalized on /insights/routing

@vercel Vercel
Copy link

vercel bot commented May 14, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2025 11:40am
cal-eu ⬜️ Ignored (Inspect) Visit Preview Aug 8, 2025 11:40am

@keithwillcode keithwillcode added consumer core area: core, team members only labels May 14, 2025
Base automatically changed from eunjae/cal-5658-create-a-dedicated-table-to-replace-routingformresponse-view to main May 14, 2025 14:41
@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5755-use-routingformresponsedenormalized-on-insightsrouting branch from 7d9028f to 7f0e10c Compare May 14, 2025 14:52
@eunjae-lee eunjae-lee changed the title fix: use RoutingFormResponseDenormalized fix: replace routingFormResponse with routingFormResponseDenormalized May 15, 2025
@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label May 30, 2025
@github-actions github-actions bot removed the Stale label Jun 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 19, 2025 •
edited
Loading

E2E results are ready!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jul 4, 2025
@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5755-use-routingformresponsedenormalized-on-insightsrouting branch from 2ee1249 to 5fd1f41 Compare July 7, 2025 09:59
@eunjae-lee eunjae-lee changed the base branch from main to eunjae/cal-5986-drop-off-funnel-chart-for-insightsrouting July 7, 2025 09:59
@delve-auditor Delve Auditor
Copy link

delve-auditor bot commented Jul 7, 2025 •
edited
Loading

✅ No security or compliance issues detected. Reviewed everything up to ea2be2e.

Security Overview
  • 🔎 Scanned files: 12 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► BookedByCell.tsx
    Update attendee type handling and email title condition
► RoutingFormResponsesTable.tsx
    Update query parameters and data handling
► RoutingKPICards.tsx
    Simplify query parameters
► RoutingFormResponsesDownload.tsx
    Update download parameters and implementation
► useInsightsColumns.tsx
    Enhance column filtering and value handling
► useInsightsParameters.ts
    Update column filter exclusions
Refactor ► routing-events.ts
    Refactor routing form stats and response handling
► trpc-router.ts
    Update routing form endpoints and service integration
► insightsRouting.ts
    Add table data and stats functionality
Bug Fix ► lib/types.ts
    Simplify response value types

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@github-actions github-actions bot removed the Stale label Jul 8, 2025
sean-brydon
sean-brydon reviewed Jul 8, 2025
View reviewed changes
sean-brydon
sean-brydon reviewed Jul 8, 2025
View reviewed changes
@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5755-use-routingformresponsedenormalized-on-insightsrouting branch from 60b066e to 6f306ed Compare July 8, 2025 13:07
Base automatically changed from eunjae/cal-5986-drop-off-funnel-chart-for-insightsrouting to main July 16, 2025 14:36
@eunjae-lee eunjae-lee force-pushed the eunjae/cal-5755-use-routingformresponsedenormalized-on-insightsrouting branch from 6f306ed to c486e25 Compare July 16, 2025 14:38
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 16, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch eunjae/cal-5755-use-routingformresponsedenormalized-on-insightsrouting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sean-brydon sean-brydon sean-brydon left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
consumer core area: core, team members only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eunjae-lee @sean-brydon @keithwillcode