feat: disable transcription setting in cal video #21755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (06/10/25)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
cubic found 1 issue across 14 files. Review it in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| @@ -174,6 +174,8 @@ export const useEventTypeForm = ({ | |||
| redirectUrlOnExit: z.string().url().nullish(), | |||
| disableRecordingForOrganizer: z.boolean().nullable(), | |||
| disableRecordingForGuests: z.boolean().nullable(), | |||
| disableTranscriptionForGuests: z.boolean().nullable(), | |||
There was a problem hiding this comment.
If calVideoSettings is present this new field becomes mandatory (only null allowed). Existing eventType objects that don’t yet include this property will fail validation. Mark the field as optional as well to keep backward-compatibility.
Suggested change
| disableTranscriptionForGuests: z.boolean().nullable(), | |
| disableTranscriptionForGuests: z.boolean().nullable().optional(), |
Udit-takkar
commented
Jun 10, 2025
Comment on lines
+379
to
+427
| {!isPlatform && ( | ||
| <Controller | ||
| name="calVideoSettings.disableTranscriptionForGuests" | ||
| defaultValue={!!eventType.calVideoSettings?.disableTranscriptionForGuests} | ||
| render={({ field: { onChange, value } }) => { | ||
| return ( | ||
| <SettingsToggle | ||
| title={t("disable_transcription_for_guests")} | ||
| labelClassName="text-sm" | ||
| checked={value} | ||
| onCheckedChange={onChange} | ||
| /> | ||
| ); | ||
| }} | ||
| /> | ||
| )} | ||
| {!isPlatform && ( | ||
| <Controller | ||
| name="calVideoSettings.disableTranscriptionForOrganizer" | ||
| defaultValue={!!eventType.calVideoSettings?.disableTranscriptionForOrganizer} | ||
| render={({ field: { onChange, value } }) => { | ||
| return ( | ||
| <SettingsToggle | ||
| title={t("disable_transcription_for_organizer")} | ||
| labelClassName="text-sm" | ||
| checked={value} | ||
| onCheckedChange={onChange} | ||
| /> | ||
| ); | ||
| }} | ||
| /> | ||
| )} | ||
|
|
Udit-takkar
commented
Jun 10, 2025
Comment on lines
+48
to
+80
| const shouldEnableTranscriptionButton = ({ | ||
| hasTeamPlan, | ||
| calVideoSettings, | ||
| isOrganizer, | ||
| }: { | ||
| hasTeamPlan: boolean; | ||
| calVideoSettings?: CalVideoSettings | null; | ||
| isOrganizer: boolean; | ||
| }) => { | ||
| if (!hasTeamPlan) return false; | ||
| if (!calVideoSettings) return true; | ||
|
|
||
| if (isOrganizer) { | ||
| return !calVideoSettings.disableTranscriptionForOrganizer; | ||
| } | ||
|
|
||
| return !calVideoSettings.disableTranscriptionForGuests; | ||
| }; | ||
|
|
There was a problem hiding this comment.
disableTranscriptionForOrganizer and disableTranscriptionForGuests default value is false
0401006 to
e8c912b
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
3 tasks
emrysal
approved these changes
Jun 18, 2025
E2E results are ready! |
BKM14
pushed a commit
to BKM14/cal.com
that referenced
this pull request
Jun 26, 2025
* feat: disable transcription setting in cal video * fix: type err
devin-ai-integration bot
added a commit
that referenced
this pull request
Jul 4, 2025
- Add disableRecordingDownloadEmailForGuests field to CalVideoSettings schema - Update repository layer to handle new field with default false value - Add UI toggle in event type setup page alongside other Cal Video settings - Modify sendDailyVideoRecordingEmails to conditionally skip attendee emails - Update webhook handler to pass calVideoSettings to email function - Add i18n translation for new toggle option - Update all TypeScript types and TRPC schemas - Create database migration for new field Follows pattern from PR #21755 for transcription settings. Only attendee emails are skipped when enabled - organizer emails always sent. Co-Authored-By: udit@cal.com <udit222001@gmail.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Summary by cubic
Added new settings to disable transcription for guests and organizers in Cal Video meetings.