refactor: ✨v2 bookings allow non utc start time #22078

shaun-ak · 2025-06-27T02:56:19Z

What does this PR do?

Users can now send start times in any ISO 8601 format:

With timezone offset (+05:30, -04:00, etc.)
With Z (UTC)
Or just a plain local time (which will be interpreted as the attendee's timezone)

Fixes #21738 (GitHub issue number)
Fixes CAL-5903 (Linear issue number - should be visible at the bottom of the GitHub issue description)

Image Demo (if applicable):

With timezone offset (+05:30):

Without any timezone, will take from attendee.timezone:

With UTC (Z) at the end:

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

Summary by cubic

Bookings now accept start times in any ISO 8601 format, including those with time zone offsets, UTC (Z), or local times based on the attendee's time zone.

Refactors
- Updated booking logic to handle non-UTC start times and correctly interpret time zones.

vercel · 2025-06-27T02:56:26Z

@shaun-ak is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

graphite-app · 2025-06-27T03:00:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (06/27/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (06/27/25)

1 label was added to this PR based on Keith Williams's automation.

cubic-dev-ai

cubic found 2 issues across 1 file. Review them in cubic.dev

_{React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.}

apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.ts

coderabbitai · 2025-07-16T03:54:37Z

Walkthrough

A new private method, parseToUTC, was introduced in the InputBookingsService_2024_08_13 class to handle the conversion of booking start times to UTC. This method checks if the input ISO string includes a timezone offset or 'Z' suffix and parses accordingly, defaulting to a provided timezone or UTC if not. All previous direct uses of timezone-aware parsing logic were replaced with calls to this new method in several booking-related methods, thereby centralizing and standardizing the handling of start time conversions to UTC. No other logic or error handling was modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

The changes are localized to a single file and primarily involve refactoring existing parsing logic into a new private method and replacing previous calls with this method. The complexity is low since no new business logic or error handling was introduced, and the scope is limited to consistent usage of the new parsing method.

Assessment against linked issues

Objective	Addressed	Explanation
Convert booking start time to UTC automatically if time with timezone is submitted (#21738, CAL-5903)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were identified.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 753a9dd and 43298e0.

📒 Files selected for processing (1)

apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.ts (5 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Install dependencies / Yarn install & cache

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

shaun-ak · 2025-08-06T02:53:17Z

Hey @anikdhabal @kart1ka , just a gentle ping if this could be reviewed.

kart1ka

LGTM

refactor: v2 bookings allow non utc start time

d09f4a5

shaun-ak requested review from a team as code owners June 27, 2025 02:56

graphite-app bot requested a review from a team June 27, 2025 02:56

graphite-app bot added the community Created by Linear-GitHub Sync label Jun 27, 2025

github-actions bot added api area: API, enterprise API, access token, OAuth platform Anything related to our platform plan 💻 refactor labels Jun 27, 2025

refactor: refactor redundant code

3837c26

cubic-dev-ai bot reviewed Jun 27, 2025

View reviewed changes

apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.ts Outdated Show resolved Hide resolved

apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.ts Outdated Show resolved Hide resolved

dosubot bot added the bookings area: bookings, availability, timezones, double booking label Jun 27, 2025

shaun-ak and others added 3 commits June 27, 2025 09:24

refactor: add hour offset regex

1c5f324

Merge branch 'main' into v2-bookings-allow-non-utc-start-time

0654442

Merge branch 'main' into v2-bookings-allow-non-utc-start-time

a410e73

anikdhabal added the Medium priority Created by Linear-GitHub Sync label Jul 4, 2025

Merge branch 'main' into v2-bookings-allow-non-utc-start-time

753a9dd

shaun-ak added 5 commits July 21, 2025 07:35

Merge branch 'main' into v2-bookings-allow-non-utc-start-time

e3e3a70

Merge branch 'main' into v2-bookings-allow-non-utc-start-time

4d3759d

Merge branch 'main' into v2-bookings-allow-non-utc-start-time

cb291db

Merge branch 'main' into v2-bookings-allow-non-utc-start-time

aab0497

Merge branch 'main' into v2-bookings-allow-non-utc-start-time

43298e0

Merge branch 'main' into v2-bookings-allow-non-utc-start-time

ded705f

kart1ka approved these changes Aug 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: ✨v2 bookings allow non utc start time #22078

refactor: ✨v2 bookings allow non utc start time #22078

Uh oh!

shaun-ak commented Jun 27, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jun 27, 2025

Uh oh!

graphite-app bot commented Jun 27, 2025

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Jul 16, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

shaun-ak commented Aug 6, 2025

Uh oh!

kart1ka left a comment

Uh oh!

Uh oh!

refactor: ✨v2 bookings allow non utc start time #22078

Are you sure you want to change the base?

refactor: ✨v2 bookings allow non utc start time #22078

Uh oh!

Conversation

shaun-ak commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Image Demo (if applicable):

Mandatory Tasks (DO NOT REMOVE)

Summary by cubic

Uh oh!

vercel bot commented Jun 27, 2025

Uh oh!

graphite-app bot commented Jun 27, 2025

Graphite Automations

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

shaun-ak commented Aug 6, 2025

Uh oh!

kart1ka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shaun-ak commented Jun 27, 2025 •

edited

Loading

coderabbitai bot commented Jul 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)